ui : card-component,whats-next,get-docker & translate : whats-next#134
Merged
Conversation
…r-ko.github.io into g1nya2-ui-translate
This was
linked to
issues
Jun 11, 2025
Closed
Closed
Collaborator
Author
|
Collaborator
Author
|
프리티어 체크가 안된다고 뜨는데 어떤건가요? 상관 있는건가요..? 궁금합니다! 로컬에서 돌릴땐 별 문제 없었습니다 |
Collaborator
Author
|
@krsy0411 프리티어 수정 후, 테스트코드 부분에서 오류가 또 나서, 살펴보니 기존 box-component 테스트코드 지우고 card-component테스트코드 추가해두었습니다! markdown.test.ts 부분입니다! 확인후 머지 부탁드립니다! |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR replaces the legacy BoxComponent with a new CardComponent, updates the markdown loader and styles to support cards, and applies these cards to "what’s next" and "get-docker" sections with Korean translations.
- Renamed BoxComponent to CardComponent in code, imports, and tests
- Enhanced
load_md.tsto parse<div>wrappers and card/button tags - Added Tailwind CSS styles for
.cardand integrated cards in docs
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/scripts/components/card-component.ts | Introduces CardComponent and registers card-component |
| src/scripts/load_md.ts | Updates markdown parsing logic to handle card-component and wrappers |
| tests/markdown.test.ts | Adjusts tests to check rendering of card-component |
| src/styles/style.css | Adds base and component styles for .card and custom element display |
| src/scripts/main.ts & components/index.ts | Replaces imports of box-component with card-component |
| public/docs/get-started/.../whats-next.md | Applies card layout and Korean translations to "What’s Next" page |
| public/docs/get-started/get-docker.md | Wraps cards in a <div> grid and replaces boxes with cards |
Comments suppressed due to low confidence (2)
src/scripts/load_md.ts:9
- The
customBlockTokenizerandblockTagRegexextensions are defined but not actually leveraged by your manual split/parsing logic; consider removing them or fully integrating withmarked.useto simplify maintenance.
const blockTagRegex = /^<(card-component)([\s\S]*?)(?:>([\s\S]*?)<\/card-component>|\s*\/)?>/i;
tests/markdown.test.ts:69
- Add a test case for rendering a
<div class="not-prose">...<card-component />...</div>wrapper so we can verify the newdivBlockRegexcorrectly preserves and inserts those blocks.
describe('renderMarkdownWithComponents', () => {
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
krsy0411
reviewed
Jun 18, 2025
Comment on lines
+58
to
+79
| body { | ||
| font-family: 'Noto Sans KR', Arial, sans-serif; | ||
| background: #f8fafc; | ||
| color: #222; | ||
| margin: 0; | ||
| padding: 0; | ||
| } | ||
|
|
||
| h1, | ||
| h2, | ||
| h3, | ||
| h4, | ||
| h5, | ||
| h6 { | ||
| font-weight: 700; | ||
| margin-top: 1.5em; | ||
| margin-bottom: 0.5em; | ||
| } | ||
|
|
||
| p { | ||
| margin: 0 0 1em 0; | ||
| } |
Collaborator
There was a problem hiding this comment.
이 전역 스타일을 추가한 이유는 뭘까요?
전역 스타일이 필요없다는 건 아닌데, card-comonent랑은 목적이 다른 코드라는 생각이여서요
Collaborator
There was a problem hiding this comment.
아니다. 이건 들어가고 제가 좀 더 정리해야할 것 같아요. 머지하겠습니다.
krsy0411
approved these changes
Jun 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
위 내용 진행하였습니다.
